Problem: gas used is not backward compatible #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - revert the changes in ethermint
|
It's being verified in testnet. |
yihuang
requested review from
JayT106 and
adu-crypto
and removed request for
a team
new version seems running ok on testnet. |
yihuang
commented
Nov 3, 2022
adu-crypto
approved these changes
Nov 3, 2022
|
Do we know which part of the ethermint change causes |
yes, that and another one, both are reverted in our custom branch: https://github.com/crypto-org-chain/ethermint/commits/release/v0.20.x-cronos |
yihuang
added a commit
that referenced
this pull request
Jan 26, 2023
* Problem: eth_sendTransaction is not tested * Problem: json-rpc apis fail for legacy blocks after upgrade (#696) * Problem: json-rpc apis fail for legacy blocks Solution: - keep the query handler in cosmos-sdk backward-compatible - add integration test to check * update sdk to upstream * ibc-go to rc2 * Problem: file changes detection in workflow is problematic (backport #703) (#705) * Problem: file changes detection in workflow is problematic Solution: - fix wildcards according the plugin's doc - reformat python * fix py-lint * Problem: after v0.9.0 upgrade eth_call failed on old blocks (backport #713) (#719) * Problem: after v0.9.0 upgrade eth_call failed on old blocks Solution: - make grpc query compatible with old format * debug * fix eth_call * fix gravity upgrade test * update ethermint to main branch * update sdk * Problem: state streamers are not integrated (backport #702) (#721) Solution: - integration the basic file streamer * add integration test * changelog * fix build * fix lint * fix deliver tx event in cosmos-sdk * fix integration test * Update integration_tests/test_streamer.py Signed-off-by: yihuang <huang@crypto.com> * update ethermint and fix build * add a small cli utility into test_streamer.py * fix integration test * update sdk to upstream Signed-off-by: yihuang <huang@crypto.com> Signed-off-by: yihuang <huang@crypto.com> * Problem: new iavl indexes migration is slow and not optional (#714) (#720) * Problem: new iavl indexes migration is slow and not optional Closes: #712 Solution: - Integrate the option introduced in cosmos-sdk * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> Signed-off-by: yihuang <huang@crypto.com> Signed-off-by: yihuang <huang@crypto.com> * Problem: recent dependencies are not used (backport #729) (#730) * Problem: recent dependencies are not used (backport #729) Solution: - update cosmos-sdk to 0.46.2, ibc-go to v5.0.0, ethermint to recent main branch Update highlights: - new flag to disable fast node migration - fix streaming listeners bug - fix grpc server panic - fix index-eth-tx error on empty db * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> Signed-off-by: yihuang <huang@crypto.com> * Problem: chain state is inconsistent if upgrade migration is interrupted (#748) * Problem: chain state is inconsistent if upgrade migration is interrupted Solution: - update cosmos-sdk with the fix * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * gomod2nix * skip streamer test Signed-off-by: yihuang <huang@crypto.com> * Problem: recent fixes in dependencies are not included (#752) * Problem: recent fixes in dependencies are not included Solution: - update cosmos-sdk and iavl * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * fix build Signed-off-by: yihuang <huang@crypto.com> * Problem: binary version is not bump to v1.0.0 (#753) * Problem: recent fixes in dependencies are not used (#757) * Problem: recent fixes in dependencies are not used Solution: - cosmos-sdk -> v0.46.4 - ethermint -> main - ibc-go -> v5.0.1 - add dragonberry ics20 replacement * maintain ethermint fork * Problem: gas used is not backward compatible (#760) Solution: - revert the changes in ethermint * Problem: evm execute result is non-deterministic with concurrent grpc query (#761) * Problem: evm execute result is non-deterministic with concurrent grpc query Solution: - update dependencies to include the fix * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update go.mod Signed-off-by: yihuang <huang@crypto.com> Signed-off-by: yihuang <huang@crypto.com> * Problem: extra_eips is not cleared on production network (#762) * Problem: extra_eips is not cleared on production network Closes: #755 Solution: - add 1.0.0 upgrade plan to clear it * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update integration_tests/test_upgrade.py Signed-off-by: yihuang <huang@crypto.com> * fix integration test Signed-off-by: yihuang <huang@crypto.com> * Problem: no error log when iavl set failure trigger app hash mismatch (#763) * Problem: no error log when iavl set failure trigger app hash mismatch Solution: - log the error in cosmos-sdk * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * PR merged Signed-off-by: yihuang <huang@crypto.com> * Problem: different result from eth_getProof comparing with Ethereum (#764) * Problem: different result from eth_getProof comparing with Ethereum Solution: - cherry-pick solution from ethermint, thanks @mmsqe * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> Signed-off-by: yihuang <huang@crypto.com> * Problem: nix exceeds github rate limit occationally in CI (backport #766) (#768) Solution: - configure access-token - update the action plugins * Problem: fixes in ibc-go v5.1 are not included (#765) * Problem: fixes in ibc-go v5.1 are not included Solution: - make a breaking change to upgrade to ibc-go `v5.1.0`. - will do v1.0.0 upgrade on both testnet and mainnet. * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * fix lint * include cache fix in tendermint * update sdk * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * make different plan name v1.0.0-testnet3 for testnet3 Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> * Problem: london hardfork number failed validation (#771) * fix upgrade set parameters * changelog * Problem: formal v0.46.5 cosmos-sdk release is not used (#772) * Problem: formal v0.46.5 cosmos-sdk release is not used Solution: - update dependency, should be non-breaking for cronos * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * update to v0.46.6 Signed-off-by: yihuang <huang@crypto.com> * Problem: final v1.0.0 is not released (#774) Solution: - update changelog * Problem: manual prune cmd is not included (backport #781) (#782) Solution: - add to root cmd * Problem: cosmos-sdk `v0.46.7` is not used (#790) * Problem: cosmos-sdk `v0.46.7` is not used Solution: - update dependency - `v0.46.7` fix a gov migration issue which affect query votes of old proposals. * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * use sdk streamers config * fix streamer test * fix file streamer integration test * changelog Signed-off-by: yihuang <huang@crypto.com> * Problem: discontinued ibc-go version (#802) * Problem: discontinued ibc-go version Solution: - update ibc-go to v5.2.0. - do another coordinated upgrade on testnet3. * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update app/upgrades.go Signed-off-by: yihuang <huang@crypto.com> Signed-off-by: yihuang <huang@crypto.com> * Problem: production rocksdb configuration is not optimal (#813) * Problem: production rocksdb configuration is not optimal Solution: - update related dependencies to allow customize rocksdb options. - especially using rocksdb v7. - tune rocksdb options. * Update Makefile Signed-off-by: yihuang <huang@crypto.com> * remove rocksdb from niv * rocksdb options * update flake * fix build * create_if_missing * OptimizeLevelStyleCompaction and IncreaseParallelism * remove SetLevelCompactionDynamicLevelBytes and add BlockCache * fix integration test * comments Signed-off-by: yihuang <huang@crypto.com> * Problem: prometheus metrics is lost (#814) * Problem: prometheus metrics is lost Solution: - setup correctly in ethermint * changelog * release v1.0.3 * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * fix changelog * fix merge * Update integration_tests/test_upgrade.py Co-authored-by: mmsqe <tqd0800210105@gmail.com> Signed-off-by: yihuang <huang@crypto.com> * fix test * Update integration_tests/configs/default.jsonnet Signed-off-by: yihuang <huang@crypto.com> * fix test_multiple_attestation_processing * fix changelog Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)